linux-kernel - Re: [PATCH -next] pci: fix a -Wtype-limits compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <935EF32D-2D9C-46AD-A266-77A259DAE91F@lca.pw>
Date:   Wed, 18 Dec 2019 15:08:38 -0500
From:   Qian Cai <cai@....pw>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     jamessewart@...sta.com, logang@...tatee.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] pci: fix a -Wtype-limits compilation warning



> On Dec 18, 2019, at 1:24 PM, Bjorn Helgaas <helgaas@...nel.org> wrote:
> 
> Ugh, that is pretty subtle!  Would you mind if we used "unsigned int"
> instead of "u16"?  "u16" makes it look like just a mistake -- somebody
> is likely to come along and say devfn only needs "u8" and try to
> change it back.  The same might happen with "unsigned int", but at
> least it doesn't look like it was chosen specifically to fit a devfn.
> 
> Provisional patch below.

Looks good to me.