linux-kernel - Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: add interrupts properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191218203818.GA8009@bogus>
Date:   Wed, 18 Dec 2019 14:38:18 -0600
From:   Rob Herring <robh@...nel.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Guillaume La Roque <glaroque@...libre.com>, marcel@...tmann.org,
        johan.hedberg@...il.com, linux-bluetooth@...r.kernel.org,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        nsaenzjulienne@...e.de, linux-kernel@...r.kernel.org,
        khilman@...libre.com
Subject: Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: add interrupts
 properties

On Fri, Dec 13, 2019 at 05:19:01PM +0100, Johan Hovold wrote:
> On Fri, Dec 13, 2019 at 04:06:21PM +0100, Guillaume La Roque wrote:
> > add interrupts and interrupt-names as optional properties
> > to support host-wakeup by interrupt properties instead of
> > host-wakeup-gpios.
> > 
> > Signed-off-by: Guillaume La Roque <glaroque@...libre.com>
> > ---
> >  Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > index b5eadee4a9a7..95912d979239 100644
> > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > @@ -36,7 +36,9 @@ Optional properties:
> >      - pcm-frame-type: short, long
> >      - pcm-sync-mode: slave, master
> >      - pcm-clock-mode: slave, master
> > -
> > + - interrupts: must be one, used to wakeup the host processor if
> > +   gpiod_to_irq function not supported
> 
> This is a Linux implementation detail which therefore doesn't belong in
> the binding.
> 
> I think the general rule is to prefer interrupts over gpios where we
> have a choice, but here the current binding already has a
> host-wakeup-gpios.
> 
> Not sure how best to handle that, maybe Rob knows.

Use gpiod_to_irqd().

You can also deprecate the gpio prop, but you have to keep driver 
support for it. And updating dts files would break old kernels with new 
dtbs.

Rob