linux-kernel - Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191218221310.GA4624@bogus>
Date:   Wed, 18 Dec 2019 16:13:10 -0600
From:   Rob Herring <robh@...nel.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     "Sandeep Maheswaram (Temp)" <sanm@...eaurora.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Felipe Balbi <balbi@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        linux-usb@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        Manu Gautam <mgautam@...eaurora.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3
 bindings

On Wed, Dec 18, 2019 at 10:37:53AM -0800, Doug Anderson wrote:
> Hi,
> 
> On Wed, Dec 18, 2019 at 4:41 AM Sandeep Maheswaram (Temp)
> <sanm@...eaurora.org> wrote:
> > +  assigned-clock-rates:
> > +    description:
> > +      Should be 19.2MHz (19200000) for MOCK_UTMI_CLK
> > +      >=125MHz (125000000) for MASTER_CLK in SS mode
> > +      >=60MHz (60000000) for MASTER_CLK in HS mode
> > +    maxItems: 2
> >
> > You can still express some limits here even if we don't go all out
> > with the "oneOf".  AKA I think this is better:
> >
> > assigned-clock-rates:
> >   items:
> >     - const: 19200000
> >     - minimum: 60000000
> >       description: >= 60 MHz in HS mode, >= 125 MHz in SS mode
> >
> > Facing error when i add as above.
> > properties:assigned-clock-rates: {'items': [{'const': 19200000}, {'minimum': 60000000}]} is not valid under any of the given schemas
> > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/qcom,dwc3.example.dts' failed

Update dtschema and you should get a better error message now.

I believe the problem is we require both minimum and maximum to be 
specified or none. Maybe we should relax that, but OTOH I doubt 4GHz is 
valid.

Rob