linux-kernel - Re: [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hbls616t3.wl-tiwai@suse.de>
Date:   Wed, 18 Dec 2019 07:33:44 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status

On Wed, 18 Dec 2019 04:42:57 +0100,
Nathan Chancellor wrote:
> 
> Clang warns:
> 
> ../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation;
> statement is not part of the previous 'if' [-Wmisleading-indentation]
>         info->version = USX2Y_DRIVER_VERSION;
>         ^
> ../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here
>         if (us428->chip_status & USX2Y_STAT_CHIP_INIT)
>         ^
> 1 warning generated.
> 
> This warning occurs because there is a space before the tab on this
> line. Remove it so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
> 
> This was introduced before the beginning of git history so no fixes tag.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/831
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied, thanks.


Takashi