linux-kernel - [PATCH] serdev: Don't claim unsupported serial devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191218065646.817493-1-punit1.agrawal@toshiba.co.jp>
Date:   Wed, 18 Dec 2019 15:56:46 +0900
From:   Punit Agrawal <punit1.agrawal@...hiba.co.jp>
To:     linux-serial@...r.kernel.org
Cc:     Punit Agrawal <punit1.agrawal@...hiba.co.jp>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        nobuhiro1.iwamatsu@...hiba.co.jp, shrirang.bagul@...onical.com,
        stable@...r.kernel.org, Rob Herring <robh@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johan Hovold <johan@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>
Subject: [PATCH] serdev: Don't claim unsupported serial devices

Serdev sub-system claims all serial devices that are not already
enumerated. As a result, no device node is created for serial port on
certain boards such as the Apollo Lake based UP2. This has the
unintended consequence of not being able to raise the login prompt via
serial connection.

Introduce a blacklist to reject devices that should not be treated as
a serdev device. Add the Intel HS UART peripheral ids to the blacklist
to bring back serial port on SoCs carrying them.

Cc: stable@...r.kernel.org
Signed-off-by: Punit Agrawal <punit1.agrawal@...hiba.co.jp>
Cc: Rob Herring <robh@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Johan Hovold <johan@...nel.org>
Cc: Hans de Goede <hdegoede@...hat.com>
---

Hi,

The patch has been updated based on feedback recieved on the RFC[0].

Please consider merging if there are no objections.

Thanks,
Punit

[0] https://www.spinics.net/lists/linux-serial/msg36646.html

 drivers/tty/serdev/core.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 226adeec2aed..0d64fb7d4f36 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -663,6 +663,12 @@ static acpi_status acpi_serdev_register_device(struct serdev_controller *ctrl,
 	return AE_OK;
 }
 
+static const struct acpi_device_id serdev_blacklist_devices[] = {
+	{"INT3511", 0},
+	{"INT3512", 0},
+	{ },
+};
+
 static acpi_status acpi_serdev_add_device(acpi_handle handle, u32 level,
 					  void *data, void **return_value)
 {
@@ -675,6 +681,10 @@ static acpi_status acpi_serdev_add_device(acpi_handle handle, u32 level,
 	if (acpi_device_enumerated(adev))
 		return AE_OK;
 
+	/* Skip if black listed */
+	if (!acpi_match_device_ids(adev, serdev_blacklist_devices))
+		return AE_OK;
+
 	if (acpi_serdev_check_resources(ctrl, adev))
 		return AE_OK;
 
-- 
2.24.0