linux-kernel - Re: [PATCH v4 1/3] perf report: Change sort order by a specified event in group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191218074351.GB19062@krava>
Date:   Wed, 18 Dec 2019 08:43:51 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v4 1/3] perf report: Change sort order by a specified
 event in group

On Wed, Dec 18, 2019 at 10:24:41AM +0800, Jin Yao wrote:

SNIP

> After:
> 
>   # perf report --group --stdio --group-sort-idx 3
> 
>   # To display the perf.data header info, please use --header/--header-only options.
>   #
>   #
>   # Total Lost Samples: 0
>   #
>   # Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, BR_MISP_RETIRED.ALL_BRANCHES:pp, cpu/event=0xc0,umask=1,cmask=1,
>   # Event count (approx.): 6451235635
>   #
>   #                         Overhead  Command    Shared Object            Symbol
>   # ................................  .........  .......................  ...................................
>   #
>       92.19%  98.68%   0.00%  93.30%  mgen       mgen                     [.] LOOP1
>        0.00%   0.13%   0.00%   6.08%  swapper    [kernel.kallsyms]        [k] intel_idle
>        3.12%   0.29%   0.00%   0.16%  gsd-color  libglib-2.0.so.0.5600.4  [.] 0x0000000000049515
>        0.00%   0.00%   0.00%   0.06%  swapper    [kernel.kallsyms]        [k] hrtimer_start_range_ns
>        1.56%   0.03%   0.00%   0.04%  gsd-color  libglib-2.0.so.0.5600.4  [.] 0x00000000000494b7
>        0.00%   0.15%   0.00%   0.04%  perf       [kernel.kallsyms]        [k] smp_call_function_single
>        0.00%   0.00%   0.00%   0.02%  mgen       [kernel.kallsyms]        [k] update_curr
>        0.00%   0.00%   0.00%   0.02%  mgen       [kernel.kallsyms]        [k] apic_timer_interrupt
>        0.00%   0.00%   0.00%   0.02%  mgen       [kernel.kallsyms]        [k] native_apic_msr_eoi_write
>        0.00%   0.00%   0.00%   0.02%  mgen       [kernel.kallsyms]        [k] __update_load_avg_se
>        0.00%   0.00%   0.00%   0.02%  mgen       [kernel.kallsyms]        [k] scheduler_tick
> 
> Now the output is sorted by the fourth event in group.
> 
>  v4:
>  ---
>  1. Update Documentation/perf-report.txt to mention
>     '--group-sort-idx' support multiple groups with different
>     amount of events and it should be used on grouped events.
> 
>  2. Update __hpp__group_sort_idx(), just return when the
>     idx is out of limit.
> 
>  3. Return failure on symbol_conf.group_sort_idx && !session->evlist->nr_groups.
>     So now we don't need to use together with --group.

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka