linux-kernel - Re: [PATCH] i3c: make 'i3c_bus_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Dec 2019 09:27:46 +0100
From:   Boris Brezillon <boris.brezillon@...labora.com>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Boris Brezillon <bbrezillon@...nel.org>
Subject: Re: [PATCH] i3c: make 'i3c_bus_set_mode' static

Hello Ben,

On Tue, 17 Dec 2019 12:01:50 +0000
"Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk> wrote:

> The function i3c_bus_set_mode() is not declared or
> exported, so make it static to avoid the following
> warning:
> 
> drivers/i3c/master.c:530:5: warning: symbol 'i3c_bus_set_mode' was not declared. Should it be static?
> 
> If it is needed in the future, then it should be declared
> and suitably exported.
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>

Thanks for this patch, but I already a similar fix [1].

Regards,

Boris

[1]https://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git/commit/?h=i3c/next&id=026d8450d499904f4712676e2149cdb758d0a601

> ---
> Cc: Boris Brezillon <bbrezillon@...nel.org>
> Cc: linux-i3c@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/i3c/master.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 043691656245..7f8f896fa0c3 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -527,8 +527,8 @@ static const struct device_type i3c_masterdev_type = {
>  	.groups	= i3c_masterdev_groups,
>  };
>  
> -int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode,
> -		     unsigned long max_i2c_scl_rate)
> +static int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode,
> +			    unsigned long max_i2c_scl_rate)
>  {
>  	struct i3c_master_controller *master = i3c_bus_to_i3c_master(i3cbus);
>