linux-kernel - Re: [PATCH v2] ext2: Adjust indentation in ext2_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Dec 2019 09:38:39 +0100
From:   Jan Kara <jack@...e.cz>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Jan Kara <jack@...e.com>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH v2] ext2: Adjust indentation in ext2_fill_super

On Tue 17-12-19 20:19:31, Nathan Chancellor wrote:
> Clang warns:
> 
> ../fs/ext2/super.c:1076:3: warning: misleading indentation; statement is
> not part of the previous 'if' [-Wmisleading-indentation]
>         sbi->s_groups_count = ((le32_to_cpu(es->s_blocks_count) -
>         ^
> ../fs/ext2/super.c:1074:2: note: previous statement is here
>         if (EXT2_BLOCKS_PER_GROUP(sb) == 0)
>         ^
> 1 warning generated.
> 
> This warning occurs because there is a space before the tab on this
> line. Remove it so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
> 
> Fixes: 41f04d852e35 ("[PATCH] ext2: fix mounts at 16T")
> Link: https://github.com/ClangBuiltLinux/linux/issues/827
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Thanks! I've added the patch to my tree.

								Honza

> ---
> 
> v1 -> v2:
> 
> * Adjust link to point to the right issue.
> 
>  fs/ext2/super.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 8643f98e9578..4a4ab683250d 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1073,9 +1073,9 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  
>  	if (EXT2_BLOCKS_PER_GROUP(sb) == 0)
>  		goto cantfind_ext2;
> - 	sbi->s_groups_count = ((le32_to_cpu(es->s_blocks_count) -
> - 				le32_to_cpu(es->s_first_data_block) - 1)
> - 					/ EXT2_BLOCKS_PER_GROUP(sb)) + 1;
> +	sbi->s_groups_count = ((le32_to_cpu(es->s_blocks_count) -
> +				le32_to_cpu(es->s_first_data_block) - 1)
> +					/ EXT2_BLOCKS_PER_GROUP(sb)) + 1;
>  	db_count = (sbi->s_groups_count + EXT2_DESC_PER_BLOCK(sb) - 1) /
>  		   EXT2_DESC_PER_BLOCK(sb);
>  	sbi->s_group_desc = kmalloc_array (db_count,
> -- 
> 2.24.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR