linux-kernel - Re: [PATCH] dt-bindings: Add missing 'properties' keyword enclosing 'snps,tso'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 18 Dec 2019 12:34:38 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexandre Torgue <alexandre.torgue@...com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org,
        Maxime Ripard <mripard@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] dt-bindings: Add missing 'properties' keyword enclosing
 'snps,tso'

On Tue, Dec 17, 2019 at 10:39:46AM -0600, Rob Herring wrote:
> DT property definitions must be under a 'properties' keyword. This was
> missing for 'snps,tso' in an if/then clause. A meta-schema fix will
> catch future errors like this.
> 
> Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas")
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

We still seem to be some distance from having all DT match the schema.

$ ARCH=arm make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/snps,dwmac.yaml
.../linux/arch/arm/boot/dts/artpec6-devboard.dt.yaml: ethernet@...10000: interrupt-names:1: 'eth_wake_irq' was expected
.../linux/arch/arm/boot/dts/meson6-atv1200.dt.yaml: ethernet@...10000: 'phy-mode' is a required property
.../linux/arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml: ethernet@...10000: 'phy-mode' is a required property
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...00000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...00000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...00000: resets: [[4, 32], [4, 40]] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...02000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...02000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...02000: resets: [[4, 33], [4, 41]] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...04000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...04000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml: ethernet@...04000: resets: [[4, 34], [4, 42]] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...00000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...00000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...00000: resets: [[4, 32], [4, 40]] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...02000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...02000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...02000: resets: [[4, 33], [4, 41]] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...04000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...04000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml: ethernet@...04000: resets: [[4, 34], [4, 42]] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...00000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...00000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...00000: resets: [[4, 32], [4, 40]] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...02000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...02000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...02000: resets: [[4, 33], [4, 41]] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...04000: reset-names: Additional items are not allowed ('stmmaceth-ocp' was unexpected)
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...04000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
.../linux/arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml: ethernet@...04000: resets: [[4, 34], [4, 42]] is too long
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: $nodename:0: 'eth@...00000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: compatible: None of ['st,spear600-gmac'] are valid under the given schema
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: $nodename:0: 'eth@...00000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: compatible: None of ['st,spear600-gmac'] are valid under the given schema
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: $nodename:0: 'eth@...00000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: compatible: None of ['st,spear600-gmac'] are valid under the given schema
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: $nodename:0: 'eth@...00000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: compatible: None of ['st,spear600-gmac'] are valid under the given schema
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: $nodename:0: 'eth@...00000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/spear1310-evb.dt.yaml: eth@...00000: compatible: None of ['st,spear600-gmac'] are valid under the given schema
.../linux/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dt.yaml: ethernet@...02000: snps,reset-delays-us: [[10000, 10000, 10000]] is too short
.../linux/arch/arm/boot/dts/spear1340-evb.dt.yaml: eth@...00000: $nodename:0: 'eth@...00000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/spear1340-evb.dt.yaml: eth@...00000: compatible: None of ['st,spear600-gmac'] are valid under the given schema
.../linux/arch/arm/boot/dts/stih410-b2260.dt.yaml: dwmac@...0000: $nodename:0: 'dwmac@...0000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/stih410-b2260.dt.yaml: dwmac@...0000: snps,reset-delays-us: [[0, 10000, 1000000]] is too short
.../linux/arch/arm/boot/dts/stih407-b2120.dt.yaml: dwmac@...0000: $nodename:0: 'dwmac@...0000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/stih418-b2199.dt.yaml: dwmac@...0000: $nodename:0: 'dwmac@...0000' does not match '^ethernet(@.*)?$'
.../linux/arch/arm/boot/dts/stih410-b2120.dt.yaml: dwmac@...0000: $nodename:0: 'dwmac@...0000' does not match '^ethernet(@.*)?$'