linux-kernel - [BUG] ALSA: ice1712: a possible sleep-in-atomic-context bug in snd_vt1724_set_pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d43135e-73b9-a46a-2155-9e91d0dcdf83@gmail.com>
Date:   Wed, 18 Dec 2019 20:25:42 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     perex@...ex.cz, tiwai@...e.com, allison@...utok.net,
        rfontana@...hat.com, tglx@...utronix.de
Cc:     alsa-devel@...a-project.org, LKML <linux-kernel@...r.kernel.org>
Subject: [BUG] ALSA: ice1712: a possible sleep-in-atomic-context bug in
 snd_vt1724_set_pro_rate()

The driver may sleep while holding a read lock.
The function call path (from bottom to top) in Linux 4.19 is:

sound/pci/ice1712/quartet.c, 414:
     mutex_lock in reg_write
sound/pci/ice1712/quartet.c, 485:
     reg_write in set_cpld
sound/pci/ice1712/quartet.c, 876:
     set_cpld in qtet_set_rate
sound/pci/ice1712/ice1724.c, 687:
     (FUNC_PTR) qtet_set_rate in snd_vt1724_set_pro_rate
sound/pci/ice1712/ice1724.c, 668:
     _raw_spin_lock_irqsave in snd_vt1724_set_pro_rate

(FUNC_PTR) means a function pointer is called.
mutex_lock() can sleep at runtime.

I am not sure how to properly fix this possible bug, so I only report it.

This bug is found by a static analysis tool STCheck written by myself.


Best wishes,
Jia-Ju Bai