linux-kernel - Re: [BUG] ALSA: soc: sti: a possible sleep-in-atomic-context bug in uni_player_ctl_iec958

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86228f2a-f75c-2b17-1e47-ea2a6abec704@st.com>
Date:   Wed, 18 Dec 2019 14:24:03 +0100
From:   Arnaud POULIQUEN <arnaud.pouliquen@...com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] ALSA: soc: sti: a possible sleep-in-atomic-context bug in
 uni_player_ctl_iec958_put()

Hi Jia-Ju

On 12/18/19 1:51 PM, Jia-Ju Bai wrote:
> The driver may sleep while holding a spinlock.
> The function call path (from bottom to top) in Linux 4.19 is:
> 
> sound/soc/sti/uniperif_player.c, 229:
>      mutex_lock in uni_player_set_channel_status
> sound/soc/sti/uniperif_player.c, 608:
>      uni_player_set_channel_status in uni_player_ctl_iec958_put
> sound/soc/sti/uniperif_player.c, 603:
>      _raw_spin_lock_irqsave in uni_player_ctl_iec958_put
> 
> mutex_lock() can sleep at runtime.
> 
> I am not sure how to properly fix this possible bug, so I only report it.
> 
> This bug is found by a static analysis tool STCheck written by myself.
Thank you for pointing out the bug, I will test and send a fix.

Regards
Arnaud
> 
> 
> Best wishes,
> Jia-Ju Bai
>