linux-kernel - Re: [PATCH 13/13] mmc: au1xmmc: switch to platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Dec 2019 15:01:43 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Yangtao Li <tiny.windzz@...il.com>
Cc:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Manuel Lauss <manuel.lauss@...il.com>
Subject: Re: [PATCH 13/13] mmc: au1xmmc: switch to platform_get_irq

- trimmed cc list (please do that also for any future submissions).

On Sun, 15 Dec 2019 at 18:51, Yangtao Li <tiny.windzz@...il.com> wrote:
>
> platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
> requesting IRQ's resources, as they can be not ready yet. Using
> platform_get_irq() instead is preferred for getting IRQ even if it
> was not retrieved earlier.
>
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>

Patch 1->13 applied for next, thanks!

Next time, please use a cover-letter when you send a series.

Kind regards
Uffe


> ---
>  drivers/mmc/host/au1xmmc.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c
> index bc8aeb47a7b4..8823680ca42c 100644
> --- a/drivers/mmc/host/au1xmmc.c
> +++ b/drivers/mmc/host/au1xmmc.c
> @@ -984,12 +984,9 @@ static int au1xmmc_probe(struct platform_device *pdev)
>                 goto out2;
>         }
>
> -       r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -       if (!r) {
> -               dev_err(&pdev->dev, "no IRQ defined\n");
> +       host->irq = platform_get_irq(pdev, 0);
> +       if (host->irq < 0)
>                 goto out3;
> -       }
> -       host->irq = r->start;
>
>         mmc->ops = &au1xmmc_ops;
>
> --
> 2.17.1
>