linux-kernel - Re: [PATCH v2 22/36] irqchip/gic-v4.1: Advertise support v4.1 to KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Dec 2019 14:48:54 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Zenghui Yu <yuzenghui@...wei.com>
Cc:     <kvmarm@...ts.cs.columbia.edu>, <linux-kernel@...r.kernel.org>,
        Eric Auger <eric.auger@...hat.com>,
        James Morse <james.morse@....com>,
        Julien Thierry <julien.thierry.kdev@...il.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Andrew Murray <andrew.murray@....com>,
        Jayachandran C <jnair@...vell.com>,
        Robert Richter <rrichter@...vell.com>
Subject: Re: [PATCH v2 22/36] irqchip/gic-v4.1: Advertise support v4.1 to KVM

On 2019-11-01 12:55, Zenghui Yu wrote:
> Hi Marc,
>
> On 2019/10/27 22:42, Marc Zyngier wrote:
>> Tell KVM that we support v4.1. Nothing uses this information so far.
>> Signed-off-by: Marc Zyngier <maz@...nel.org>
>> ---
>>   drivers/irqchip/irq-gic-v3-its.c       | 9 ++++++++-
>>   drivers/irqchip/irq-gic-v3.c           | 1 +
>>   include/linux/irqchip/arm-gic-common.h | 2 ++
>>   3 files changed, 11 insertions(+), 1 deletion(-)
>> diff --git a/drivers/irqchip/irq-gic-v3-its.c 
>> b/drivers/irqchip/irq-gic-v3-its.c
>> index df259e202482..6483f8051b3e 100644
>> --- a/drivers/irqchip/irq-gic-v3-its.c
>> +++ b/drivers/irqchip/irq-gic-v3-its.c
>> @@ -4580,6 +4580,7 @@ int __init its_init(struct fwnode_handle 
>> *handle, struct rdists *rdists,
>>   	struct device_node *of_node;
>>   	struct its_node *its;
>>   	bool has_v4 = false;
>> +	bool has_v4_1 = false;
>>   	int err;
>>
>>   	gic_rdists = rdists;
>> @@ -4600,8 +4601,14 @@ int __init its_init(struct fwnode_handle 
>> *handle, struct rdists *rdists,
>>   	if (err)
>>   		return err;
>>   -	list_for_each_entry(its, &its_nodes, entry)
>> +	list_for_each_entry(its, &its_nodes, entry) {
>>   		has_v4 |= is_v4(its);
>> +		has_v4_1 |= is_v4_1(its);
>> +	}
>> +
>> +	/* Don't bother with inconsistent systems */
>> +	if (WARN_ON(!has_v4_1 && rdists->has_rvpeid))
>> +		rdists->has_rvpeid = false;
>>
>>   	if (has_v4 & rdists->has_vlpis) {
>>   		if (its_init_vpe_domain() ||
>> diff --git a/drivers/irqchip/irq-gic-v3.c 
>> b/drivers/irqchip/irq-gic-v3.c
>> index f0d33ac64a99..94dddfb21076 100644
>> --- a/drivers/irqchip/irq-gic-v3.c
>> +++ b/drivers/irqchip/irq-gic-v3.c
>> @@ -1758,6 +1758,7 @@ static void __init 
>> gic_of_setup_kvm_info(struct device_node *node)
>>   		gic_v3_kvm_info.vcpu = r;
>>
>>   	gic_v3_kvm_info.has_v4 = gic_data.rdists.has_vlpis;
>> +	gic_v3_kvm_info.has_v4_1 = gic_data.rdists.has_rvpeid;
>
> Also set gic_v3_kvm_info.has_v4_1 in gic_acpi_setup_kvm_info().

Indeed. Now fixed.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...