linux-kernel - Re: [RFC] btf: Some structs are doubled because of struct ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191218112219.309d1031@gandalf.local.home>
Date:   Wed, 18 Dec 2019 11:22:19 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Toke Høiland-Jørgensen 
        <toke@...hat.com>, Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        Quentin Monnet <quentin.monnet@...ronome.com>
Subject: Re: [RFC] btf: Some structs are doubled because of struct
 ring_buffer

On Wed, 18 Dec 2019 17:14:01 +0100
Jiri Olsa <jolsa@...hat.com> wrote:

> On Sat, Dec 14, 2019 at 12:35:10PM +0100, Jiri Olsa wrote:
> > On Fri, Dec 13, 2019 at 02:05:31PM -0500, Steven Rostedt wrote:
> > 
> > SNIP
> >   
> > >  	struct trace_array *tr = filp->private_data;
> > > -	struct ring_buffer *buffer = tr->trace_buffer.buffer;
> > > +	struct trace_buffer *buffer = tr->trace_buffer.buffer;
> > >  	unsigned long val;
> > >  	int ret;
> > >  
> > > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> > > index 63bf60f79398..308fcd673102 100644
> > > --- a/kernel/trace/trace.h
> > > +++ b/kernel/trace/trace.h
> > > @@ -178,7 +178,7 @@ struct trace_option_dentry;
> > >  
> > >  struct trace_buffer {
> > >  	struct trace_array		*tr;
> > > -	struct ring_buffer		*buffer;
> > > +	struct trace_buffer		*buffer;  
> > 
> > perf change is fine, but 'trace_buffer' won't work because
> > we already have 'struct trace_buffer' defined in here
> > 
> > maybe we could change this name to trace_buffer_array?  
> 
> ..like in patch below? it's independent of your previous changes
> 
>

Actually, I would prefer to call it either trace_array_buffer, or just
array_buffer.

-- Steve