linux-kernel - RE: [PATCH] PCI: altera: Adjust indentation in altera_pcie_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR11MB450901255175CCA4C7CDBF3BCC530@MN2PR11MB4509.namprd11.prod.outlook.com>
Date:   Wed, 18 Dec 2019 02:30:40 +0000
From:   "Tan, Ley Foon" <ley.foon.tan@...el.com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
CC:     Andrew Murray <andrew.murray@....com>,
        "rfi@...ts.rocketboards.org" <rfi@...ts.rocketboards.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "clang-built-linux@...glegroups.com" 
        <clang-built-linux@...glegroups.com>
Subject: RE: [PATCH] PCI: altera: Adjust indentation in
 altera_pcie_valid_device



> -----Original Message-----
> From: Nathan Chancellor <natechancellor@...il.com>
> Sent: Wednesday, December 18, 2019 9:28 AM
> To: Ley Foon Tan <lftan@...era.com>; Lorenzo Pieralisi
> <lorenzo.pieralisi@....com>; Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Andrew Murray <andrew.murray@....com>; rfi@...ts.rocketboards.org;
> linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org; clang-built-
> linux@...glegroups.com; Nathan Chancellor <natechancellor@...il.com>
> Subject: [PATCH] PCI: altera: Adjust indentation in altera_pcie_valid_device
> 
> Clang warns:
> 
> ../drivers/pci/controller/pcie-altera.c:196:3: warning: misleading indentation;
> statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>          return true;
>          ^
> ../drivers/pci/controller/pcie-altera.c:193:2: note: previous statement is here
>         if (bus->number == pcie->root_bus_nr && dev > 0)
>         ^
> 1 warning generated.
> 
> This warning occurs because there is a space after the tab on this line.
> Remove it so that the indentation is consistent with the Linux kernel coding
> style and clang no longer warns.
> 
> Fixes: eaa6111b70a7 ("PCI: altera: Add Altera PCIe host controller driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/815
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Reviewed-by: Ley Foon Tan <ley.foon.tan@...el.com>

Thanks.

Regards
Ley Foon

> ---
>  drivers/pci/controller/pcie-altera.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-
> altera.c
> index b447c3e4abad..24cb1c331058 100644
> --- a/drivers/pci/controller/pcie-altera.c
> +++ b/drivers/pci/controller/pcie-altera.c
> @@ -193,7 +193,7 @@ static bool altera_pcie_valid_device(struct
> altera_pcie *pcie,
>         if (bus->number == pcie->root_bus_nr && dev > 0)
>                 return false;
> 
> -        return true;
> +       return true;
>  }
> 
>  static int tlp_read_packet(struct altera_pcie *pcie, u32 *value)
> --
> 2.24.1
> 
> 
> ________________________________
> 
> Confidentiality Notice.
> This message may contain information that is confidential or otherwise
> protected from disclosure. If you are not the intended recipient, you are
> hereby notified that any use, disclosure, dissemination, distribution, or
> copying of this message, or any attachments, is strictly prohibited. If you
> have received this message in error, please advise the sender by reply e-mail,
> and delete the message and any attachments. Thank you.