linux-kernel - Re: [PATCH] Revert "serdev: simplify Makefile"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191218163335.GM22665@localhost>
Date:   Wed, 18 Dec 2019 17:33:35 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Johan Hovold <johan@...nel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Rob Herring <robh@...nel.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH] Revert "serdev: simplify Makefile"

On Wed, Dec 18, 2019 at 03:00:16PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 18, 2019 at 02:11:54PM +0100, Johan Hovold wrote:
> > This reverts commit 54edb425346a4d5e17f7e54e8c97c0d0eac26315.
> > 
> > The offending commit caused serdev core to always be built-in, something
> > which breaks the build of dependent modules when serdev is being built
> > as a module:
> > 
> > ERROR: "__serdev_device_driver_register" [drivers/gnss/gnss-ubx.ko] undefined!
> > ...
> > make[2]: *** [/home/johan/work/omicron/src/linux/scripts/Makefile.modpost:94: __modpost] Error 1
> > 
> > Reported-by: kbuild test robot <lkp@...el.com>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---
> >  drivers/tty/serdev/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Heh, give me a chance to catch up here, I would have reverted it on my
> own :)

Heh, good. :)

> I'll go queue this up now, thanks.

Johan