linux-kernel - Re: [PATCH RESEND RESEND] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Dec 2019 18:51:53 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Andrey Konovalov <andreyknvl@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Will Deacon <will@...nel.org>, linux-media@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH RESEND RESEND] media: uvc: Avoid cyclic entity chains due
 to malformed USB descriptors

On Wed, Dec 18, 2019 at 01:46:00PM +0100, Andrey Konovalov wrote:
> On Wed, Dec 18, 2019 at 1:23 PM Greg Kroah-Hartman wrote:
> > On Wed, Dec 18, 2019 at 11:41:38AM +0000, Will Deacon wrote:
> >> On Mon, Dec 16, 2019 at 02:17:52PM +0100, Andrey Konovalov wrote:
> >>> On Mon, Dec 16, 2019 at 1:16 PM Will Deacon <will@...nel.org> wrote:
> >>>> On Fri, Nov 08, 2019 at 05:55:03PM +0200, Laurent Pinchart wrote:
> >>>>> Thank you for the patch.
> >>>>>
> >>>>> I'm sorry for the delay, and will have to ask you to be a bit more
> >>>>> patient I'm afraid. I will leave tomorrow for a week without computer
> >>>>> access and will only be able to go through my backlog when I will be
> >>>>> back on the 17th.
> >>>>
> >>>> Gentle reminder on this, now you've been back a month ;)
> >>>
> >>> I think we now have a reproducer for this issue that syzbot just reported:
> >>>
> >>> https://syzkaller.appspot.com/bug?extid=0a5c96772a9b26f2a876
> >>>
> >>> You can try you patch on it :)
> >>
> >> Oh wow, I *really* like the raw USB gadget thingy you have to reproduce
> >> these! I also really like that this patch fixes the issue. Logs below.
> 
> Thanks! An easier way to test the patch would be to issue a syz test
> command, but I'm glad you managed to set up raw gadget manually and it
> worked for you.
> 
> >
> > Ok, that's a good poke for me to go review that raw gadget code to see
> > if it can be merged upstream :)
> 
> Looking forward to it! =)

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

and merged in my tree. I'm so sorry for the way too long delay.

> >> Laurent -- can we please merge this now?
> >
> > Yes, that would be good to have, as this obviously fixes a problem, and
> > I can take it off of my "patches to track" list....

-- 
Regards,

Laurent Pinchart