linux-kernel - Re: [PATCH] ath11k: fix missing free of skb on error return path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191218175411.CA98AC43383@smtp.codeaurora.org>
Date:   Wed, 18 Dec 2019 17:54:11 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Colin King <colin.king@...onical.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Pradeep Kumar Chitrapu <pradeepc@...eaurora.org>,
        Ganesh Sesetti <gseset@...eaurora.org>,
        Karthikeyan Periyasamy <periyasa@...eaurora.org>,
        John Crispin <john@...ozen.org>, ath11k@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ath11k: fix missing free of skb on error return path

Colin King <colin.king@...onical.com> wrote:

> The error handling when the call to ath11k_hal_srng_get_entrysize fails
> leaks skb, fix this by returning via the err_free return path that will
> ensure the skb is free'd.
> 
> Addresses-Coverity: ("Resource leak")
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

4358bcb54bb9 ath11k: fix missing free of skb on error return path

-- 
https://patchwork.kernel.org/patch/11289341/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches