linux-kernel - Re: [PATCH v3] platform/mellanox: fix the mlx-bootctl sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfYwxviATZnmYcgzkKKGw47ki=BZQYw4xRmUrfNqsiBww@mail.gmail.com>
Date:   Wed, 18 Dec 2019 19:59:43 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Liming Sun <lsun@...lanox.com>
Cc:     Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Vadim Pasternak <vadimp@...lanox.com>,
        David Woods <dwoods@...lanox.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] platform/mellanox: fix the mlx-bootctl sysfs

On Wed, Dec 18, 2019 at 5:25 PM Liming Sun <lsun@...lanox.com> wrote:
>
> This is a follow-up commit for the sysfs attributes to change
> from DRIVER_ATTR to DEVICE_ATTR according to some initial comments.
> In such case, it's better to point the sysfs path to the device
> itself instead of the driver. The ABI document is also updated.
>
> Fixes: 79e29cb8fbc5 ("platform/mellanox: Add bootctl driver for Mellanox BlueField Soc")
> Signed-off-by: Liming Sun <lsun@...lanox.com>

...

> -ATTRIBUTE_GROUPS(mlxbf_bootctl);

What's wrong with above macro?

> +static const struct attribute_group mlxbf_bootctl_group = {
> +       .attrs  = mlxbf_bootctl_attrs,
> +};

...

> +static const struct attribute_group *mlxbf_bootctl_dev_groups[] = {
> +       &mlxbf_bootctl_group,
> +       NULL
> +};

-- 
With Best Regards,
Andy Shevchenko