linux-kernel - Re: [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4gCqt1cfEb4KFWW+J+FcQj8ZnYEFz-ggLzgR2Zs+Wg13w@mail.gmail.com>
Date:   Wed, 18 Dec 2019 21:19:25 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Michal Hocko <mhocko@...e.com>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory_block

On Wed, Dec 18, 2019 at 8:10 PM Anshuman Khandual
<anshuman.khandual@....com> wrote:
>
> memory_block structure elements 'hw' and 'phys_callback' are not getting
> used. This was originally added with commit 3947be1969a9 ("[PATCH] memory
> hotplug: sysfs and add/remove functions") but never seem to have been used.
> Just drop them now.
>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Pavel Tatashin <pasha.tatashin@...een.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
> ---
>  include/linux/memory.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index 0ebb105eb261..4e95a9eb8061 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -29,8 +29,6 @@ struct memory_block {
>         int section_count;              /* serialized by mem_sysfs_mutex */
>         int online_type;                /* for passing data to online routine */
>         int phys_device;                /* to which fru does this belong? */
> -       void *hw;                       /* optional pointer to fw/hw data */
> -       int (*phys_callback)(struct memory_block *);
>         struct device dev;
>         int nid;                        /* NID for this memory block */
>  };
> --
> 2.20.1

Looks good.

Reviewed-by: Dan Williams <dan.j.williams@...el.com>