linux-kernel - Re: [PATCH AUTOSEL 5.4 177/350] regulator: fixed: add off-on-delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191219194012.GP17708@sasha-vm>
Date:   Thu, 19 Dec 2019 14:40:12 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH AUTOSEL 5.4 177/350] regulator: fixed: add off-on-delay

On Wed, Dec 11, 2019 at 10:59:34AM +0000, Mark Brown wrote:
>On Tue, Dec 10, 2019 at 04:04:42PM -0500, Sasha Levin wrote:
>> From: Peng Fan <peng.fan@....com>
>>
>> [ Upstream commit f7907e57aea2adcd0b57ebcca410e125412ab680 ]
>>
>> Depends on board design, the gpio controlling regulator may
>> connects with a big capacitance. When need off, it takes some time
>> to let the regulator to be truly off. If not add enough delay, the
>> regulator might have always been on, so introduce off-on-delay to
>> handle such case.
>
>This is clearly adding a new feature and doesn't include the matching DT
>binding addition for that new feature.

This new "feature" fixes a bug, no? Should we take the DT bindings as
well?

-- 
Thanks,
Sasha