[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191219203742.GA27539@bogus>
Date: Thu, 19 Dec 2019 14:38:09 -0600
From: Rob Herring <robh@...nel.org>
To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc: devicetree@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
linux-kernel@...r.kernel.org, Mason Yang <masonccyang@...c.com.tw>,
linux-spi@...r.kernel.org, Chris Brandt <chris.brandt@...esas.com>
Subject: Re: [PATCH RFC 1/2] dt-bindings: memory: document Renesas RPC-IF
bindings
On Tue, Dec 10, 2019 at 10:37:34PM +0300, Sergei Shtylyov wrote:
> Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or
> HyperFlash connected to the SoC to be accessed via the external address
> space read mode or the manual mode.
>
> Document the device tree bindings for the Renesas RPC-IF found in the R-Car
> gen3 SoCs.
>
> Based on the original patch by Mason Yang <masonccyang@...c.com.tw>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>
> ---
> Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.txt | 52 ++++++++++
> 1 file changed, 52 insertions(+)
Please convert to DT schema.
>
> Index: linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.txt
> ===================================================================
> --- /dev/null
> +++ linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.txt
> @@ -0,0 +1,52 @@
> +Renesas Reduced Pin Count Interface (RPC-IF)
> +--------------------------------------------
> +
> +Renesas RPC-IF allows a SPI flash or HyperFlash connected to the SoC to
> +be accessed via the external address space read mode or the manual mode.
> +
> +Required properties:
> +- compatible: should be an SoC-specific compatible value, followed by
> + "renesas,rcar-gen3-rpc-if" as a fallback.
> + supported SoC-specific values are:
> + "renesas,r8a77980-rpc-if" (R-Car V3H),
> + "renesas,r8a77995-rpc-if" (R-Car D3).
> +- reg: should list 3 register areas:
> + 1st for the RPC-IF registers,
> + 2nd for the direct mapping read mode,
> + 3rd for the write buffer area.
> +- reg-names: should contain "regs", "dirmap", and "wbuf".
> +- clocks: should contain the clock phandle/specifier pair for the module clock.
> +- power-domains: should contain the power domain phandle/specifier pair.
> +- resets: should contain the reset controller phandle/specifier pair.
> +- #address-cells: should be 1.
> +- #size-cells: should be 0.
> +
> +The flash chip itself should be represented by a subnode of the RPC-IF node.
> +The flash interface is selected based on the "compatible" property of this
> +subnode:
> +- if it contains "jedec,spi-nor", then SPI is used;
> +- if it contains "cfi-flash", then HyperFlash is used.
> +
> +Example:
> +
> + rpc: spi@...00000 {
> + compatible = "renesas,r8a77995-rpc-if",
> + "renesas,rcar-gen3-rpc-if";
> + reg = <0 0xee200000 0 0x200>,
> + <0 0x08000000 0 0x4000000>,
> + <0 0xee208000 0 0x100>;
> + reg-names = "regs", "dirmap", "wbuf";
> + clocks = <&cpg CPG_MOD 917>;
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 917>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <40000000>;
> + spi-tx-bus-width = <1>;
> + spi-rx-bus-width = <1>;
> + };
> + };
Powered by blists - more mailing lists