linux-kernel - Re: refcount_warn_saturate WARNING (was: Re: cls_flower: Fix the behavior using port ranges with hw-offload)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Dec 2019 22:01:39 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Yoshiki Komachi <komachi.yoshiki@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Amritha Nambiar <amritha.nambiar@...el.com>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: refcount_warn_saturate WARNING (was: Re: cls_flower: Fix the
 behavior using port ranges with hw-offload)

Hi Cong,

On Thu, Dec 19, 2019 at 9:50 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Thu, Dec 19, 2019 at 2:12 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > I still see the below warning on m68k/ARAnyM during boot with v5.5-rc2
> > and next-20191219.
> > Reverting commit 8ffb055beae58574 ("cls_flower: Fix the behavior using
> > port ranges with hw-offload") fixes that.
> >
> > As this is networking, perhaps this is seen on big-endian only?
> > Or !CONFIG_SMP?
> >
> > Do you have a clue?
> > I'm especially worried as this commit is already being backported to stable.
> > Thanks!
>
> I did a quick look at the offending commit, I can't even connect it to
> any dst refcnt.
>
> Do you have any more information? Like what happened before the
> warning? Does your system use cls_flower filters at all? If so, please
> share your tc configurations.

No, I don't use clf_flower filters.  This is just a normal old Debian boot,
where the root file system is being remounted, followed by the warning.

To me, it also looks very strange.  But it's 100% reproducible for me.
Git bisect pointed to this commit, and reverting it fixes the issue.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds