linux-kernel - Re: [PATCH v5] lib/dynamic_debug: make better dynamic log output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec04aa8b-5c2a-28be-a32b-6d85a17d2f21@akamai.com>
Date:   Thu, 19 Dec 2019 17:10:49 -0500
From:   Jason Baron <jbaron@...mai.com>
To:     Huang Shijie <sjhuang@...vatar.ai>
Cc:     linux-kernel@...r.kernel.org, 1537577747@...com,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v5] lib/dynamic_debug: make better dynamic log output



On 12/19/19 2:47 AM, Huang Shijie wrote:
> The driver strings, device name and net device name are not changed for
> the driver's dynamic log output. But the dynamic_emit_prefix() which contains
> the function names may change when the function names are changed.
> 
> So the patch makes the better dynamic log output.

Another point here is that currently the output precisely matches the
non-dynamic debug counterpart strings if not prefix is emitted. So that
changes with this patch. I think its nice to say that the output is the
same as the non dynamic debug output except it may have an optional
prefix....


> 
> Signed-off-by: Huang Shijie <sjhuang@...vatar.ai>
> ---
> v4 --> v5:
> 	remove the redundant whitespce in the tail.
> ---
>  lib/dynamic_debug.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index c60409138e13..bfc3b386d603 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -589,9 +589,9 @@ void __dynamic_dev_dbg(struct _ddebug *descriptor,
>  	} else {
>  		char buf[PREFIX_SIZE];
>  
> -		dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s%s %s: %pV",
> -				dynamic_emit_prefix(descriptor, buf),
> +		dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s %s %s%pV",
>  				dev_driver_string(dev), dev_name(dev),
> +				dynamic_emit_prefix(descriptor, buf),
>  				&vaf);
>  	}
>  
> @@ -619,11 +619,11 @@ void __dynamic_netdev_dbg(struct _ddebug *descriptor,
>  		char buf[PREFIX_SIZE];
>  
>  		dev_printk_emit(LOGLEVEL_DEBUG, dev->dev.parent,
> -				"%s%s %s %s%s: %pV",
> -				dynamic_emit_prefix(descriptor, buf),
> +				"%s %s %s %s %s%pV",
>  				dev_driver_string(dev->dev.parent),
>  				dev_name(dev->dev.parent),
>  				netdev_name(dev), netdev_reg_state(dev),
> +				dynamic_emit_prefix(descriptor, buf),
>  				&vaf);
>  	} else if (dev) {
>  		printk(KERN_DEBUG "%s%s: %pV", netdev_name(dev),
> @@ -655,11 +655,11 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
>  		char buf[PREFIX_SIZE];
>  
>  		dev_printk_emit(LOGLEVEL_DEBUG, ibdev->dev.parent,
> -				"%s%s %s %s: %pV",
> -				dynamic_emit_prefix(descriptor, buf),
> +				"%s %s %s %s%pV",
>  				dev_driver_string(ibdev->dev.parent),
>  				dev_name(ibdev->dev.parent),
>  				dev_name(&ibdev->dev),
> +				dynamic_emit_prefix(descriptor, buf),
>  				&vaf);
>  	} else if (ibdev) {
>  		printk(KERN_DEBUG "%s: %pV", dev_name(&ibdev->dev), &vaf);
>