linux-kernel - Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1pngjc2pr.fsf@oracle.com>
Date:   Thu, 19 Dec 2019 18:31:12 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Michal Suchánek <msuchanek@...e.de>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation


Michal,

>> Please don't introduce a blist flag to work around deficiencies in the
>> matching interface. I suggest you tweak the matching functions so they
>> handle a NULL vendor string correctly.
>
> I don't think that will work with the interface for dynamically adding
> entries through sysfs.

Please make it work :)

There's nothing conceptually wrong with being able to do:

        echo ":Model:Flags" > /proc/scsi/device_info

We keep running into issues where the same device needs to be listed
many times because it gets branded by different vendors.

Brownie points for making all this less clunky. The libata globbing
blacklist works much better, fwiw.

-- 
Martin K. Petersen	Oracle Linux Engineering