linux-kernel - Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191219003256.GA28144@roeck-us.net>
Date:   Wed, 18 Dec 2019 16:32:57 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bart Van Assche <bvanassche@....org>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-ide@...r.kernel.org,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives

On Wed, Dec 18, 2019 at 07:15:07PM -0500, Martin K. Petersen wrote:
> 
> Guenter,
> 
> > This driver solves this problem by adding support for reading the
> > temperature of SATA drives from the kernel using the hwmon API and
> > by adding a temperature zone for each drive.
> 
> My working tree is available here:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git/log/?h=5.6/drivetemp
> 
> A few notes:
> 
>  - Before applying your patch I did s/satatemp/drivetemp/
> 
>  - I get a crash in the driver core during probe if the drivetemp module
>    is loaded prior to loading ahci or a SCSI HBA driver. This crash is
>    unrelated to my changes. Haven't had time to debug.
> 
>  - I tweaked your ATA detection heuristics and now use the cached VPD
>    page 0x89 instead of fetching one from the device.
> 
>  - I also added support for reading the temperature log page on SCSI
>    drives.
> 
>  - Tested with a mixed bag of about 40 SCSI and SATA drives attached.
> 
>  - I still think sensor naming needs work. How and where are the
>    "drivetemp-scsi-8-140" names generated?
> 
Quick one: In libsensors, outside the kernel. The naming is generic,
along the line of <driver name>-<bus name>-<bus index>-<slot>.

> I'll tinker some more but thought I'd share what I have for now.
> 
Thanks for sharing. I'll be out on vacation until January 1. I'll look
at the code after I am back.

Guenter

> -- 
> Martin K. Petersen	Oracle Linux Engineering