linux-kernel - Re: [PATCH v2 2/4] nvmem: add support for the write-protect pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adc6cace-5ee8-5e17-3edc-79b35f00159c@linaro.org>
Date:   Thu, 19 Dec 2019 10:58:17 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Khouloud Touil <ktouil@...libre.com>, bgolaszewski@...libre.com,
        robh+dt@...nel.org, mark.rutland@....com,
        baylibre-upstreaming@...ups.io
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-i2c@...r.kernel.org, linus.walleij@...aro.org
Subject: Re: [PATCH v2 2/4] nvmem: add support for the write-protect pin



On 10/12/2019 15:41, Khouloud Touil wrote:
> The write-protect pin handling looks like a standard property that
> could benefit other users if available in the core nvmem framework.
> 
> Instead of modifying all the memory drivers to check this pin, make
> the NVMEM subsystem check if the write-protect GPIO being passed
> through the nvmem_config or defined in the device tree and pull it
> low whenever writing to the memory.
> 
> There was a suggestion for introducing the gpiodesc from pdata, but
> as pdata is already removed it could be replaced by adding it to
> nvmem_config.
> 
> Reference: https://lists.96boards.org/pipermail/dev/2018-August/001056.html
> 
> Signed-off-by: Khouloud Touil <ktouil@...libre.com>
> ---
>   drivers/nvmem/core.c           | 19 +++++++++++++++++--
>   drivers/nvmem/nvmem.h          |  2 ++
>   include/linux/nvmem-provider.h |  3 +++
>   3 files changed, 22 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>