linux-kernel - Re: [PATCH RFC] sched: Micro optimization in pick_next_task() and in check_preempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191219085042.0a29437b@gandalf.local.home>
Date:   Thu, 19 Dec 2019 08:50:42 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        bsegall@...gle.com, mgorman@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] sched: Micro optimization in pick_next_task() and
 in check_preempt_curr()

On Thu, 19 Dec 2019 15:39:14 +0300
Kirill Tkhai <ktkhai@...tuozzo.com> wrote:

> @@ -6569,6 +6558,11 @@ void __init sched_init(void)
>  	unsigned long ptr = 0;
>  	int i;
>  
> +	BUG_ON(&idle_sched_class > &fair_sched_class ||
> +		&fair_sched_class > &rt_sched_class ||
> +		&rt_sched_class > &dl_sched_class ||
> +		&dl_sched_class > &stop_sched_class);
> +

Can this be a BUILD_BUG_ON? These address should all be constants.

-- Steve



>  	wait_bit_init();
>