linux-kernel - [PATCH] mailbox: make cmd_dma a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191219170145.334021-1-ben.dooks@codethink.co.uk>
Date:   Thu, 19 Dec 2019 17:01:45 +0000
From:   "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
To:     linux-kernel@...ts.codethink.co.uk
Cc:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH] mailbox: make cmd_dma a __le64 to reduce warnings

The cmd_dma of the brcm_sba_command is often set from the
result of cpu_to_le64, which means it should really be an
__le64 type to avoid warnings such as:

drivers/dma/bcm-sba-raid.c:583:25: warning: incorrect type in assignment (different base types)
drivers/dma/bcm-sba-raid.c:583:25:    expected unsigned long long [usertype]
drivers/dma/bcm-sba-raid.c:583:25:    got restricted __le64 [usertype]

Note, this header dos not seem to be covered by the maintainers
file, so just sending to the normal lists.

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>
---
Cc: bcm-kernel-feedback-list@...adcom.com
Cc: linux-arm-kernel@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org
---
 include/linux/mailbox/brcm-message.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mailbox/brcm-message.h b/include/linux/mailbox/brcm-message.h
index 18da82115476..db49dc360a6b 100644
--- a/include/linux/mailbox/brcm-message.h
+++ b/include/linux/mailbox/brcm-message.h
@@ -21,7 +21,7 @@ enum brcm_message_type {
 
 struct brcm_sba_command {
 	u64 cmd;
-	u64 *cmd_dma;
+	__le64 *cmd_dma;
 	dma_addr_t cmd_dma_addr;
 #define BRCM_SBA_CMD_TYPE_A		BIT(0)
 #define BRCM_SBA_CMD_TYPE_B		BIT(1)
-- 
2.24.0