linux-kernel - Re: [PATCH 1/3] power: supply: ab8500: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191219170703.ek57v3o6z6ivsxaz@earth.universe>
Date:   Thu, 19 Dec 2019 18:07:03 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Ma Feng <mafeng.ma@...wei.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] power: supply: ab8500: Remove unneeded semicolon

Hi,

On Thu, Dec 19, 2019 at 09:46:29AM +0800, Ma Feng wrote:
> Fixes coccicheck warning:
> 
> drivers/power/supply/ab8500_fg.c:2224:5-6: Unneeded semicolon
> drivers/power/supply/ab8500_fg.c:2227:4-5: Unneeded semicolon
> drivers/power/supply/ab8500_fg.c:2334:3-4: Unneeded semicolon
> drivers/power/supply/ab8500_fg.c:2342:3-4: Unneeded semicolon
> drivers/power/supply/ab8500_fg.c:2350:3-4: Unneeded semicolon
> drivers/power/supply/ab8500_fg.c:2358:3-4: Unneeded semicolon
> drivers/power/supply/ab8500_fg.c:2366:3-4: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ma Feng <mafeng.ma@...wei.com>
> ---

Thanks, I queued all 3 patches to power-supply's for-next branch.

-- Sebastian

>  drivers/power/supply/ab8500_fg.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c
> index c3912ee..b96f90a 100644
> --- a/drivers/power/supply/ab8500_fg.c
> +++ b/drivers/power/supply/ab8500_fg.c
> @@ -2221,10 +2221,10 @@ static int ab8500_fg_get_ext_psy_data(struct device *dev, void *data)
>  						ab8500_fg_update_cap_scalers(di);
>  					queue_work(di->fg_wq, &di->fg_work);
>  					break;
> -				};
> +				}
>  			default:
>  				break;
> -			};
> +			}
>  			break;
>  		case POWER_SUPPLY_PROP_TECHNOLOGY:
>  			switch (ext->desc->type) {
> @@ -2331,7 +2331,7 @@ static int ab8500_fg_init_hw_registers(struct ab8500_fg *di)
>  		if (ret) {
>  			dev_err(di->dev, "%s write failed AB8505_RTC_PCUT_MAX_TIME_REG\n", __func__);
>  			goto out;
> -		};
> +		}
>  
>  		ret = abx500_set_register_interruptible(di->dev, AB8500_RTC,
>  			AB8505_RTC_PCUT_FLAG_TIME_REG, di->bm->fg_params->pcut_flag_time);
> @@ -2339,7 +2339,7 @@ static int ab8500_fg_init_hw_registers(struct ab8500_fg *di)
>  		if (ret) {
>  			dev_err(di->dev, "%s write failed AB8505_RTC_PCUT_FLAG_TIME_REG\n", __func__);
>  			goto out;
> -		};
> +		}
>  
>  		ret = abx500_set_register_interruptible(di->dev, AB8500_RTC,
>  			AB8505_RTC_PCUT_RESTART_REG, di->bm->fg_params->pcut_max_restart);
> @@ -2347,7 +2347,7 @@ static int ab8500_fg_init_hw_registers(struct ab8500_fg *di)
>  		if (ret) {
>  			dev_err(di->dev, "%s write failed AB8505_RTC_PCUT_RESTART_REG\n", __func__);
>  			goto out;
> -		};
> +		}
>  
>  		ret = abx500_set_register_interruptible(di->dev, AB8500_RTC,
>  			AB8505_RTC_PCUT_DEBOUNCE_REG, di->bm->fg_params->pcut_debounce_time);
> @@ -2355,7 +2355,7 @@ static int ab8500_fg_init_hw_registers(struct ab8500_fg *di)
>  		if (ret) {
>  			dev_err(di->dev, "%s write failed AB8505_RTC_PCUT_DEBOUNCE_REG\n", __func__);
>  			goto out;
> -		};
> +		}
>  
>  		ret = abx500_set_register_interruptible(di->dev, AB8500_RTC,
>  			AB8505_RTC_PCUT_CTL_STATUS_REG, di->bm->fg_params->pcut_enable);
> @@ -2363,7 +2363,7 @@ static int ab8500_fg_init_hw_registers(struct ab8500_fg *di)
>  		if (ret) {
>  			dev_err(di->dev, "%s write failed AB8505_RTC_PCUT_CTL_STATUS_REG\n", __func__);
>  			goto out;
> -		};
> +		}
>  	}
>  out:
>  	return ret;
> -- 
> 2.6.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)