linux-kernel - Re: [PATCH v2 2/3] misc: xilinx_flex: Add support for the flex noc Performance Monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191219172139.GB2092676@kroah.com>
Date:   Thu, 19 Dec 2019 18:21:39 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     shubhrajyoti.datta@...il.com
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, arnd@...db.de, robh+dt@...nel.org,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
Subject: Re: [PATCH v2 2/3] misc: xilinx_flex: Add support for the flex noc
 Performance Monitor

On Fri, Dec 06, 2019 at 11:09:57AM +0530, shubhrajyoti.datta@...il.com wrote:
> +/**
> + * xflex_remove - Driver remove function
> + * @pdev: Pointer to the platform_device structure
> + *
> + * This function frees all the resources allocated to the device.
> + *
> + * Return: 0 always
> + */

No need for kerneldoc documentation for static functions.

> +static int xflex_remove(struct platform_device *pdev)
> +{
> +	sysfs_remove_groups(&pdev->dev.kobj, xflex_groups);

Your attribute groups can, and should, be automatically created by the
driver core.  Set the driver's dev_groups pointer and that will happen
for you.

thanks,

greg k-h