linux-kernel - Re: [PATCH 2/2] mfd: cros_ec: Add usbpd-notify to usbpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACeCKae3gAjxeDCaGARk_r3T-k6L6OyowbOnYF3mk2sWpVo-fg@mail.gmail.com>
Date:   Thu, 19 Dec 2019 16:48:58 -0800
From:   Prashant Malani <pmalani@...omium.org>
To:     Benson Leung <bleung@...omium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger

On Thu, Dec 19, 2019 at 4:14 PM Benson Leung <bleung@...omium.org> wrote:
>
> Hey Prashant,
>
> On Thu, Dec 19, 2019 at 12:14 PM Prashant Malani <pmalani@...omium.org> wrote:
> >
> > Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
> > subdevice on non-ACPI platforms.
> >
> > This driver allows other cros-ec devices to receive PD event
> > notifications from the Chrome OS Embedded Controller (EC) via a
> > notification chain.
> >
> > Change-Id: I4c062d261fa1a504b43b0a0c0a98a661829593b9
>
> Make sure to strip Gerrit's Change-Ids before sending upstream. They
> don't have any meaning outside of chromiumos.
Done. Thanks!
>
> > Signed-off-by: Prashant Malani <pmalani@...omium.org>
> > ---
> >  drivers/mfd/cros_ec_dev.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > index c4b977a5dd966..1dde480f35b93 100644
> > --- a/drivers/mfd/cros_ec_dev.c
> > +++ b/drivers/mfd/cros_ec_dev.c
> > @@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {
> >  static const struct mfd_cell cros_usbpd_charger_cells[] = {
> >         { .name = "cros-usbpd-charger", },
> >         { .name = "cros-usbpd-logger", },
> > +#ifndef CONFIG_ACPI
> > +       { .name = "cros-usbpd-notify", },
> > +#endif
> >  };
> >
> >  static const struct cros_feature_to_cells cros_subdevices[] = {
> > --
> > 2.24.1.735.g03f4e72817-goog
> >
>
>
> --
> Benson Leung
> Staff Software Engineer
> Chrome OS Kernel
> Google Inc.
> bleung@...gle.com
> Chromium OS Project
> bleung@...omium.org