linux-kernel - Re: [PATCH v7 05/12] dmaengine: Add support for reporting DMA cached data amount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea912bfb-a315-a230-85e9-9c9110b3f0d7@ti.com>
Date:   Fri, 20 Dec 2019 12:13:19 +0200
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Vinod Koul <vkoul@...nel.org>
CC:     <robh+dt@...nel.org>, <nm@...com>, <ssantosh@...nel.org>,
        <dan.j.williams@...el.com>, <dmaengine@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <grygorii.strashko@...com>, <lokeshvutla@...com>,
        <t-kristo@...com>, <tony@...mide.com>, <j-keerthy@...com>,
        <vigneshr@...com>
Subject: Re: [PATCH v7 05/12] dmaengine: Add support for reporting DMA cached
 data amount



On 20/12/2019 11.57, Vinod Koul wrote:
> On 20-12-19, 10:49, Peter Ujfalusi wrote:
> 
>>>> +static inline void dma_set_in_flight_bytes(struct dma_tx_state *state,
>>>> +					   u32 in_flight_bytes)
>>>> +{
>>>> +	if (state)
>>>> +		state->in_flight_bytes = in_flight_bytes;
>>>> +}
>>>
>>> This would be used by dmaengine drivers right, so lets move it to drivers/dma/dmaengine.h
>>>
>>> lets not expose this to users :)
>>
>> I have put it where the dma_set_residue() was.
>> I can add a patch first to move dma_set_residue() then add
> 
> not sure I follow, but dma_set_residue() in already in drivers/dma/dmaengine.h

and this patch adds the dma_set_in_flight_bytes() to
drivers/dma/dmaengine.h

in include/linux/dmaengine.h the dma_tx_state struct is updated only.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki