linux-kernel - Re: [PATCH v7 02/12] dt-bindings: mfd: Document ROHM BD71828 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Dec 2019 10:55:05 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
Cc:     "dmurphy@...com" <dmurphy@...com>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "jacek.anaszewski@...il.com" <jacek.anaszewski@...il.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "pavel@....cz" <pavel@....cz>,
        "broonie@...nel.org" <broonie@...nel.org>
Subject: Re: [PATCH v7 02/12] dt-bindings: mfd: Document ROHM BD71828 bindings

On Fri, 20 Dec 2019, Vaittinen, Matti wrote:

> 
> On Thu, 2019-12-19 at 14:36 +0000, Lee Jones wrote:
> > On Thu, 19 Dec 2019, Vaittinen, Matti wrote:
> > 
> > > Hello Mark, Lee, Rob
> > > 
> > > I just noticed we have a dependency here. This binding is referring
> > > to
> > > regulator binding - which was applied by Mark and is thus missing
> > > from
> > > the series. What's the best way forward?
> > > 
> > > On Thu, 2019-12-19 at 11:46 +0200, Matti Vaittinen wrote:
> > > > ROHM BD71828 Power management IC integrates 7 buck converters, 7
> > > > LDOs,
> > > > a real-time clock (RTC), 3 GPO/regulator control pins, HALL input
> > > > and a 32.768 kHz clock gate.
> > > > 
> > > > Document the dt bindings drivers are using.
> > > > 
> > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com
> > > > >
> > > > Reviewed-by: Rob Herring <robh@...nel.org>
> > > > ---
> > > > 
> > > > No changes since v6
> > > 
> > > //snip
> > > 
> > > > +  regulators:
> > > > +    $ref: ../regulator/rohm,bd71828-regulator.yaml
> > > 
> > > This file is missing from the series and is applied to Mark's tree.
> > 
> > Shouldn't matter.  I guess they're all heading for he same release.
> > 
> Ok. Thanks for clarification. I was asking this because Rob asked me to
> reorder the patches a few versions ago so that the dt_binding_check
> Make target would not be broken between commits. He asked me to submit
> the regulator and LED bindings first and MFD (which refers to those)
> only after them. Thus I was wondering if the final merge order of MFD
> and regulator trees is such that it can result the breakage Rob hoped
> to avoid. But I am more than glad if the series can go in like this :)

It's not something that concerns me personally.  I only care about
*build* breakages.  Rob might be more upset about it however.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog