linux-kernel - Re: [PATCH] phy: qualcomm: Adjust indentation in read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5743631-5e45-ef36-d1b5-61f445fd7018@ti.com>
Date:   Fri, 20 Dec 2019 16:55:07 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Nathan Chancellor <natechancellor@...il.com>
CC:     Andy Gross <agross@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] phy: qualcomm: Adjust indentation in read_poll_timeout



On 18/12/19 11:59 am, Bjorn Andersson wrote:
> On Tue 17 Dec 17:36 PST 2019, Nathan Chancellor wrote:
> 
>> Clang warns:
>>
>> ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:83:4: warning:
>> misleading indentation; statement is not part of the previous 'if'
>> [-Wmisleading-indentation]
>>                  usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
>>                  ^
>> ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:80:3: note: previous
>> statement is here
>>                 if (readl_relaxed(addr) & mask)
>>                 ^
>> 1 warning generated.
>>
>> This warning occurs because there is a space after the tab on this line.
>> Remove it so that the indentation is consistent with the Linux kernel
>> coding style and clang no longer warns.
>>
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

merged, thanks!

-Kishon
> 
>> Fixes: 1de990d8a169 ("phy: qcom: Add driver for QCOM APQ8064 SATA PHY")
>> Link: https://github.com/ClangBuiltLinux/linux/issues/816
>> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
>> ---
>>  drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
>> index 42bc5150dd92..febe0aef68d4 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
>> @@ -80,7 +80,7 @@ static int read_poll_timeout(void __iomem *addr, u32 mask)
>>  		if (readl_relaxed(addr) & mask)
>>  			return 0;
>>  
>> -		 usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
>> +		usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
>>  	} while (!time_after(jiffies, timeout));
>>  
>>  	return (readl_relaxed(addr) & mask) ? 0 : -ETIMEDOUT;
>> -- 
>> 2.24.1
>>