linux-kernel - Re: [PATCH v2] nfc: s3fwrn5: replace the assertion with a WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191219.173335.447023512566099980.davem@davemloft.net>
Date:   Thu, 19 Dec 2019 17:33:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     pakki001@....edu
Cc:     kjlu@....edu, r.baldyga@...sung.com, k.opasiak@...sung.com,
        linux-nfc@...ts.01.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nfc: s3fwrn5: replace the assertion with a WARN_ON

From: Aditya Pakki <pakki001@....edu>
Date: Tue, 17 Dec 2019 14:43:00 -0600

> In s3fwrn5_fw_recv_frame, if fw_info->rsp is not empty, the
> current code causes a crash via BUG_ON. However, s3fwrn5_fw_send_msg
> does not crash in such a scenario. The patch replaces the BUG_ON
> by returning the error to the callers and frees up skb.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>

Applied.