linux-kernel - Re: [PATCH v6 1/4] perf report: Fix incorrectly added dimensions as switch perf data file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Dec 2019 14:53:58 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v6 1/4] perf report: Fix incorrectly added dimensions as
 switch perf data file

On Fri, Dec 20, 2019 at 09:37:19AM +0800, Jin Yao wrote:
> We observed an issue that was some extra columns displayed after switching
> perf data file in browser. The steps to reproduce:
> 
> 1. perf record -a -e cycles,instructions -- sleep 3
> 2. perf report --group
> 3. In browser, we use hotkey 's' to switch to another perf.data
> 4. Now in browser, the extra columns 'Self' and 'Children' are displayed.
> 
> The issue is setup_sorting() executed again after repeat path, so dimensions
> are added again.
> 
> This patch checks the last key returned from __cmd_report(). If it's
> K_SWITCH_INPUT_DATA, skips the setup_sorting().
> 
>  v6:
>  ---
>  No change.
> 
>  v5:
>  ---
>  New patch in v5.
> 
> Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>

for all 4 patches:

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka