linux-kernel - Re: [PATCH next] drm/amd/display: make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3461e773-19db-c7a0-6512-d485da828a1a@amd.com>
Date:   Fri, 20 Dec 2019 10:09:38 -0500
From:   Harry Wentland <hwentlan@....com>
To:     Chen Zhou <chenzhou10@...wei.com>, harry.wentland@....com,
        sunpeng.li@....com, alexander.deucher@....com
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next] drm/amd/display: make some symbols static

On 2019-12-20 1:55 a.m., Chen Zhou wrote:
> Make some structs and functions static to fix build warnings, parts of
> warnings are as follows:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:744:21:
> 	warning: symbol 'dce110_clock_source_create' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:768:6:
> 	warning: symbol 'dce110_clock_source_destroy' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index bf14e9a..87227db 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -741,7 +741,7 @@ struct dce_i2c_hw *dce110_i2c_hw_create(
>  
>  	return dce_i2c_hw;
>  }
> -struct clock_source *dce110_clock_source_create(
> +static struct clock_source *dce110_clock_source_create(
>  	struct dc_context *ctx,
>  	struct dc_bios *bios,
>  	enum clock_source_id id,
> @@ -765,7 +765,7 @@ struct clock_source *dce110_clock_source_create(
>  	return NULL;
>  }
>  
> -void dce110_clock_source_destroy(struct clock_source **clk_src)
> +static void dce110_clock_source_destroy(struct clock_source **clk_src)
>  {
>  	struct dce110_clk_src *dce110_clk_src;
>  
> @@ -1007,7 +1007,7 @@ static bool dce110_validate_bandwidth(
>  	return result;
>  }
>  
> -enum dc_status dce110_validate_plane(const struct dc_plane_state *plane_state,
> +static enum dc_status dce110_validate_plane(const struct dc_plane_state *plane_state,
>  				     struct dc_caps *caps)
>  {
>  	if (((plane_state->dst_rect.width * 2) < plane_state->src_rect.width) ||
> @@ -1062,7 +1062,7 @@ static bool dce110_validate_surface_sets(
>  	return true;
>  }
>  
> -enum dc_status dce110_validate_global(
> +static enum dc_status dce110_validate_global(
>  		struct dc *dc,
>  		struct dc_state *context)
>  {
> @@ -1305,7 +1305,7 @@ static void bw_calcs_data_update_from_pplib(struct dc *dc)
>  		1000);
>  }
>  
> -const struct resource_caps *dce110_resource_cap(
> +static const struct resource_caps *dce110_resource_cap(
>  	struct hw_asic_id *asic_id)
>  {
>  	if (ASIC_REV_IS_STONEY(asic_id->hw_internal_rev))
>