linux-kernel - RE: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0a52eb552a54a2c8c447145eec9bd47@exukdagfar01.INTERNAL.ROOT.TES>
Date:   Fri, 20 Dec 2019 15:30:17 +0000
From:   "Kim, David" <david.kim@...pher.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Magee, Tim" <tim.magee@...pher.com>
Subject: RE: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices

> > +/**
> > + * PCI device ID table.  We use the driver_data field to hold an
> > +index into
> > + * nfp_drvlist, so bear than in mind when editing either.
> > + */
> > +static struct pci_device_id nfp_pci_tbl[] = {
> > +{
> > +PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_21555,
> > +PCI_VENDOR_ID_NCIPHER,
> PCI_SUBSYSTEM_ID_NFAST_REV1, 0,
> > +0, /* Ignore class */
> > +0 /* Index into nfp_drvlist */
>
> Please use the correct PCI_DEVICE() macros, that should work here, right?
>
> And you are grabbing an Intel PCI device id?

We've removed our redefinition of PCI_VENDOR_ID_INTEL and are now using the PCI_DEVICE_SUB macro to define these structs.

>
> And kerneldoc everywhere, your commenting format for all of the code is a
> bit "odd".
>

All the commenting format should be better now.

Thanks,
Dave


David Kim
Senior Software Engineer
Tel: +44 1223 703449

nCipher Security
One Station Square
Cambridge CB1 2GA
United Kingdom