linux-kernel - Re: [PATCH] vsprintf: spread "const char *"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191219210451.6c96e6e5@rorschach.local.home>
Date:   Thu, 19 Dec 2019 21:04:51 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     pmladek@...e.com, sergey.senozhatsky@...il.com,
        andriy.shevchenko@...ux.intel.com, linux@...musvillemoes.dk,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] vsprintf: spread "const char *"

On Thu, 19 Dec 2019 20:34:58 +0300
Alexey Dobriyan <adobriyan@...il.com> wrote:

What does 'spread "const char*"' mean?

And you need to have a change log. Did this cause a warning? If so,
please show it in the change log.

-- Steve


> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
> 
>  lib/vsprintf.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1550,7 +1550,7 @@ static noinline_for_stack
>  char *ip_addr_string(char *buf, char *end, const void *ptr,
>  		     struct printf_spec spec, const char *fmt)
>  {
> -	char *err_fmt_msg;
> +	const char *err_fmt_msg;
>  
>  	if (check_pointer(&buf, end, ptr, spec))
>  		return buf;