linux-kernel - Re: [PATCH] soc: renesas: rcar-rst: fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWgtOh=MN3wEgTcnQFTBjUwxXUaBvRknxhzQk2DYzN7gA@mail.gmail.com>
Date:   Fri, 20 Dec 2019 17:13:07 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: renesas: rcar-rst: fix __iomem on configure call

Hi Ben,

On Wed, Dec 18, 2019 at 2:52 PM Ben Dooks (Codethink)
<ben.dooks@...ethink.co.uk> wrote:
> The configure call back takes a register pointer, so should
> have been marked with __iomem. Add this to silence the
> following sparse warnings:
>
> rivers/soc/renesas/rcar-rst.c:33:22: warning: incorrect type in initializer (incompatible argument 1 (different address spaces))

d

> drivers/soc/renesas/rcar-rst.c:33:22:    expected int ( *configure )( ... )
> drivers/soc/renesas/rcar-rst.c:33:22:    got int ( * )( ... )
> drivers/soc/renesas/rcar-rst.c:97:40: warning: incorrect type in argument 1 (different address spaces)
> drivers/soc/renesas/rcar-rst.c:97:40:    expected void *base
> drivers/soc/renesas/rcar-rst.c:97:40:    got void [noderef] <asn:2> *[assigned] base
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>

Thanks!

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-devel for v5.6...

> --- a/drivers/soc/renesas/rcar-rst.c
> +++ b/drivers/soc/renesas/rcar-rst.c
> @@ -21,7 +21,7 @@ static int rcar_rst_enable_wdt_reset(void __iomem *base)
>
>  struct rst_config {
>         unsigned int modemr;            /* Mode Monitoring Register Offset */
> -       int (*configure)(void *base);   /* Platform specific configuration */
> +       int (*configure)(void __iomem *base);   /* Platform specific configuration */

... with s/configuration/config/ to conform to the 80-char line limit.

>  };
>
>  static const struct rst_config rcar_rst_gen1 __initconst = {

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds