linux-kernel - Re: [RFC PATCH v3 2/7] interconnect: Relax requirement in of_icc_get_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGTfZH2mh4xcUUa+z=thdnrFsEgZ7NR5nmL4sK2ybARndhn01A@mail.gmail.com>
Date:   Sun, 22 Dec 2019 02:20:24 +0900
From:   Chanwoo Choi <chanwoo@...nel.org>
To:     Artur Świgoń <a.swigon@...sung.com>
Cc:     devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>, inki.dae@...sung.com,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        Georgi Djakov <georgi.djakov@...aro.org>,
        Leonard Crestez <leonard.crestez@....com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [RFC PATCH v3 2/7] interconnect: Relax requirement in of_icc_get_from_provider()

Hi,

On Fri, Dec 20, 2019 at 9:03 PM Artur Świgoń <a.swigon@...sung.com> wrote:
>
> This patch relaxes the condition in of_icc_get_from_provider() so that it
> is no longer required to set #interconnect-cells = <1> in the DT. In case
> of the devfreq driver for exynos-bus, #interconnect-cells is always zero.

It doesn't contain why don't need to require it. If you add more detailed
description, it is better to understand.

>
> Signed-off-by: Artur Świgoń <a.swigon@...sung.com>
> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/interconnect/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index e6035c199369..74c68898a350 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -335,7 +335,7 @@ struct icc_node *of_icc_get_from_provider(struct of_phandle_args *spec)
>         struct icc_node *node = ERR_PTR(-EPROBE_DEFER);
>         struct icc_provider *provider;
>
> -       if (!spec || spec->args_count != 1)
> +       if (!spec)
>                 return ERR_PTR(-EINVAL);
>
>         mutex_lock(&icc_lock);
> --
> 2.17.1
>


-- 
Best Regards,
Chanwoo Choi