[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20191220.211947.847462480497514150.davem@davemloft.net>
Date: Fri, 20 Dec 2019 21:19:47 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: alexchan@...k.com.hk
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] llc2: Fix return statement of
llc_stat_ev_rx_null_dsap_xid_c (and _test_c)
From: "Chan Shu Tak, Alex" <alexchan@...k.com.hk>
Date: Thu, 19 Dec 2019 14:16:18 +0800
> From: "Chan Shu Tak, Alex" <alexchan@...k.com.hk>
>
> When a frame with NULL DSAP is received, llc_station_rcv is called.
> In turn, llc_stat_ev_rx_null_dsap_xid_c is called to check if it is a NULL
> XID frame. The return statement of llc_stat_ev_rx_null_dsap_xid_c returns 1
> when the incoming frame is not a NULL XID frame and 0 otherwise. Hence, a
> NULL XID response is returned unexpectedly, e.g. when the incoming frame is
> a NULL TEST command.
>
> To fix the error, simply remove the conditional operator.
>
> A similar error in llc_stat_ev_rx_null_dsap_test_c is also fixed.
>
> Signed-off-by: Chan Shu Tak, Alex <alexchan@...k.com.hk>
Applied.
Powered by blists - more mailing lists