linux-kernel - Re: [PATCH v2 2/4] dt-bindings: regulator: add document bindings for mpq7920

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191222131252.ajrat2kxcyvozzia@gilmour.lan>
Date:   Sun, 22 Dec 2019 14:12:52 +0100
From:   Maxime Ripard <mripard@...nel.org>
To:     Saravanan Sekar <sravanhome@...il.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, shawnguo@...nel.org, heiko@...ech.de,
        sam@...nborg.org, icenowy@...c.io,
        laurent.pinchart@...asonboard.com, gregkh@...uxfoundation.org,
        Jonathan.Cameron@...wei.com, davem@...emloft.net,
        mchehab+samsung@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: regulator: add document bindings for
 mpq7920

On Sun, Dec 22, 2019 at 12:40:27AM +0100, Saravanan Sekar wrote:
> Add device tree binding information for mpq7920 regulator driver.
> Example bindings for mpq7920 are added.
>
> Signed-off-by: Saravanan Sekar <sravanhome@...il.com>
> ---
>  .../bindings/regulator/mpq7920.yaml           | 135 ++++++++++++++++++
>  1 file changed, 135 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/mpq7920.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/mpq7920.yaml b/Documentation/devicetree/bindings/regulator/mpq7920.yaml
> new file mode 100644
> index 000000000000..a60d3ef04c05
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mpq7920.yaml
> @@ -0,0 +1,135 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mpq7920.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Monolithic Power System MPQ7920 PMIC
> +
> +maintainers:
> +  - Saravanan Sekar <sravanhome@...il.com>
> +
> +properties:
> +  $nodename:
> +    pattern: "mpq@[0-9a-f]{1,2}"

This is still not a valid node name

> +  compatible:
> +    enum:
> +	- mps,mpq7920
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:
> +    type: object
> +    description: |
> +      list of regulators provided by this controller, must be named
> +      after their hardware counterparts BUCK[1-4], one LDORTC, and LDO[2-5]
> +      The valid names for regulators are
> +      buck1, buck2, buck3, buck4, ldortc, ldo2, ldo3, ldo4, ldo5

These should be validated.

> +  properties:

If it's properties under the regulators node, it should be at one more
indentation level.

> +       mps,time-slot:

This should have an allOf here

> +         - $ref: "/schemas/types.yaml#/definitions/uint8"
> +         - enum: [ 0, 1, 2, 3 ]
> +         - default: 0
> +       description: |
> +         each regulator output shall be delayed during power on/off sequence which
> +         based on configurable time slot value, must be one of following corresponding
> +         value 0.5ms, 2ms, 8ms, 16ms

And this should be under the property, not at the same level.

Did you run dt_bindings_check?

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)