linux-kernel - Re: [PATCH 9/9] memory: omap-gpmc: switch to platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Dec 2019 09:25:20 +0200
From:   Roger Quadros <rogerq@...com>
To:     Yangtao Li <tiny.windzz@...il.com>, <ssantosh@...nel.org>,
        <paul@...pouillou.net>, <matthias.bgg@...il.com>,
        <tony@...mide.com>, <lukasz.luba@....com>, <kgene@...nel.org>,
        <krzk@...nel.org>, <thierry.reding@...il.com>,
        <jonathanh@...dia.com>, <allison@...utok.net>,
        <tglx@...utronix.de>, <yong.wu@...iatek.com>, <jroedel@...e.de>,
        <evgreen@...omium.org>, <rfontana@...hat.com>, <digetx@...il.com>,
        <pdeschrijver@...dia.com>, <john@...ozen.org>,
        <alexios.zavras@...el.com>, <sboyd@...nel.org>,
        <kstewart@...uxfoundation.org>, <info@...ux.net>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>, <linux-omap@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 9/9] memory: omap-gpmc: switch to platform_get_irq


On 22/12/2019 20:50, Yangtao Li wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
> requesting IRQ's resources, as they can be not ready yet. Using
> platform_get_irq() instead is preferred for getting IRQ even if it
> was not retrieved earlier.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>

Acked-by: Roger Quadros <rogerq@...com>

> ---
>   drivers/memory/omap-gpmc.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index eff26c1b1394..6dd19d168f75 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2366,13 +2366,9 @@ static int gpmc_probe(struct platform_device *pdev)
>   	if (IS_ERR(gpmc_base))
>   		return PTR_ERR(gpmc_base);
>   
> -	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -	if (!res) {
> -		dev_err(&pdev->dev, "Failed to get resource: irq\n");
> -		return -ENOENT;
> -	}
> -
> -	gpmc->irq = res->start;
> +	gpmc->irq = platform_get_irq(pdev, 0);
> +	if (gpmc->irq < 0)
> +		return gpmc->irq;
>   
>   	gpmc_l3_clk = devm_clk_get(&pdev->dev, "fck");
>   	if (IS_ERR(gpmc_l3_clk)) {
> 

-- 
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki