linux-kernel - Re: [PATCH v3] Documentation: filesystems: convert fuse to RST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91ded87c-ca70-bcf7-49fc-fa2988f4e36b@darmarit.de>
Date:   Mon, 23 Dec 2019 08:37:33 +0100
From:   Markus Heiser <markus.heiser@...marit.de>
To:     "Daniel W. S. Almeida" <dwlsalmeida@...il.com>, corbet@....net,
        miklos@...redi.hu
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        skhan@...uxfoundation.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3] Documentation: filesystems: convert fuse to RST

Hi Daniel,

just some nits ...

Am 23.12.19 um 02:22 schrieb Daniel W. S. Almeida:
> From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
...

> diff --git a/Documentation/filesystems/fuse.txt b/Documentation/filesystems/fuse.rst
> similarity index 79%
> rename from Documentation/filesystems/fuse.txt
> rename to Documentation/filesystems/fuse.rst
> index 13af4a49e7db..1ca3aac04606 100644
> --- a/Documentation/filesystems/fuse.txt
> +++ b/Documentation/filesystems/fuse.rst
> @@ -1,41 +1,39 @@

...

>   Filesystem type
> -~~~~~~~~~~~~~~~
> +===============
>   
>   The filesystem type given to mount(2) can be one of the following:
>   
> -'fuse'
> +    **fuse**
>   

drop empty line, use definition list[1] / you used definition list everywhere 
except here.  I guess the follwowing matches better:


``fuse``
   This is the usual way to mount a FUSE filesystem. ...

``fuseblk``
   The filesystem is block device based. ..

[1] 
https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#definition-lists

-- Markus --