linux-kernel - Re: [PATCH] k3dma: Avoid null pointer traversal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191223075143.GC2536@vkoul-mobl>
Date:   Mon, 23 Dec 2019 13:21:43 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     John Stultz <john.stultz@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Dan Williams <dan.j.williams@...el.com>, ryan@...ted.us,
        aserbinski@...il.com, dmaengine@...r.kernel.org
Subject: Re: [PATCH] k3dma: Avoid null pointer traversal

On 18-12-19, 19:09, John Stultz wrote:
> In some cases we seem to submit two transactions in a row, which
> causes us to lose track of the first. If we then cancel the
> request, we may still get an interrupt, which traverses a null
> ds_run value.
> 
> So try to avoid starting a new transaction if the ds_run value
> is set.
> 
> While this patch avoids the null pointer crash, I've had some
> reports of the k3dma driver still getting confused, which
> suggests the ds_run/ds_done value handling still isn't quite
> right. However, I've not run into an issue recently with it
> so I think this patch is worth pushing upstream to avoid the
> crash.

Applied after adding dmaengine tag, thanks

-- 
~Vinod