linux-kernel - Re: [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27d4c933-8117-f38e-d4da-e58326fc6ee4@skidata.com>
Date:   Mon, 23 Dec 2019 08:46:02 +0100
From:   Richard Leitner <richard.leitner@...data.com>
To:     Dmitry Osipenko <digetx@...il.com>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <thierry.reding@...il.com>,
        <jonathanh@...dia.com>
CC:     <devicetree@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes

Hi,
thanks for the reply.

On 20/12/2019 15:00, Dmitry Osipenko wrote:
> 19.12.2019 16:04, Richard Leitner пишет:
>> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
>> to alias it from derived boards.
>>
>> Signed-off-by: Richard Leitner <richard.leitner@...data.com>
>> ---
>>   arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)

...

> 
> Hello Richard,
> 
> Why derived boards couldn't label nodes by themselves? That's what all
> derived boards are doing already.

Of course they can, but IMHO its more useful to have the same labels for
all derived boards.

> 
> BTW, upstream should benefit from the submitted changes. This is not a
> very useful change for upstream if you're not updating the actual DTs of
> any of the boards in arch/arm/boot/dts/*.

That's true. I thought of also patching the actual DTs but wasn't sure
if that should be in the same series...
Based on your answer I guess it should be.

Therefore I'll send a v2 soon.

Thanks again & regards;richard.l