linux-kernel - Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <209a1d81-00f7-ab22-ccca-36c1a014b345@redhat.com>
Date:   Mon, 23 Dec 2019 16:43:40 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Yangtao Li <tiny.windzz@...il.com>, mst@...hat.com
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource


On 2019/12/23 上午3:08, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource, devm_request_mem_region and
> devm_ioremap.
>
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>   drivers/virtio/virtio_mmio.c | 15 +++------------
>   1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index e09edb5c5e06..97d5725fd9a2 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d)
>   static int virtio_mmio_probe(struct platform_device *pdev)
>   {
>   	struct virtio_mmio_device *vm_dev;
> -	struct resource *mem;
>   	unsigned long magic;
>   	int rc;
>   
> -	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!mem)
> -		return -EINVAL;
> -
> -	if (!devm_request_mem_region(&pdev->dev, mem->start,
> -			resource_size(mem), pdev->name))
> -		return -EBUSY;
> -
>   	vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL);
>   	if (!vm_dev)
>   		return -ENOMEM;
> @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev)
>   	INIT_LIST_HEAD(&vm_dev->virtqueues);
>   	spin_lock_init(&vm_dev->lock);
>   
> -	vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem));
> -	if (vm_dev->base == NULL)
> -		return -EFAULT;
> +	vm_dev->base = devm_platform_ioremap_resource(pdev, 0);
> +	if (IS_ERR(vm_dev->base))
> +		return PTR_ERR(vm_dev->base);
>   
>   	/* Check magic value */
>   	magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE);


Acked-by: Jason Wang <jasowang@...hat.com>