linux-kernel - Re: [PATCH 2/2] usb: dwc2: fix debugfs FIFO count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11124aeb-ee8e-5794-5773-cdbcc662137c@synopsys.com>
Date:   Mon, 23 Dec 2019 09:11:17 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     John Keeping <john@...anate.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH 2/2] usb: dwc2: fix debugfs FIFO count



On 12/19/2019 3:34 PM, John Keeping wrote:
> The number of FIFOs may be lower than the number of endpoints.  Use the
> correct total when printing FIFO details in debugfs.
> 
> Signed-off-by: John Keeping <john@...anate.com>
> ---

Acked-by: Minas Harutyunyan <hminas@...opsys.com>


>   drivers/usb/dwc2/debugfs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c
> index b8f2790abf91..3a0dcbfbc827 100644
> --- a/drivers/usb/dwc2/debugfs.c
> +++ b/drivers/usb/dwc2/debugfs.c
> @@ -183,6 +183,7 @@ DEFINE_SHOW_ATTRIBUTE(state);
>   static int fifo_show(struct seq_file *seq, void *v)
>   {
>   	struct dwc2_hsotg *hsotg = seq->private;
> +	int fifo_count = dwc2_hsotg_tx_fifo_count(hsotg);
>   	u32 val;
>   	int idx;
>   
> @@ -196,7 +197,7 @@ static int fifo_show(struct seq_file *seq, void *v)
>   
>   	seq_puts(seq, "\nPeriodic TXFIFOs:\n");
>   
> -	for (idx = 1; idx < hsotg->num_of_eps; idx++) {
> +	for (idx = 1; idx <= fifo_count; idx++) {
>   		val = dwc2_readl(hsotg, DPTXFSIZN(idx));
>   
>   		seq_printf(seq, "\tDPTXFIFO%2d: Size %d, Start 0x%08x\n", idx,
>